-
Notifications
You must be signed in to change notification settings - Fork 51
chore: add missing dev dependency #635
chore: add missing dev dependency #635
Conversation
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
IMO, for a devDependency
, request
is fine.
I'm not able to get the system tests to fail locally using the exact same node version on either Linux or OS X. So I'm still investigating the failure. |
Codecov Report
@@ Coverage Diff @@
## master #635 +/- ##
=========================================
Coverage ? 92.91%
=========================================
Files ? 38
Lines ? 3544
Branches ? 105
=========================================
Hits ? 3293
Misses ? 228
Partials ? 23
Continue to review full report at Codecov.
|
@DominicKramer Looking at the failure, it seems like we are getting a nock failure. We seem to be trying to contact the metadata service to look up an instance property. The e2e test already has a nock for the cloud-debug-nodejs/src/agent/debuglet.ts Line 386 in 1368b62
The only reason we would reach this line is if Anyhow, there are probably two ways you can fix this.
|
I have a tentative fix for 2 in this commit you can cherry pick: 7367af3 |
…/cloud-debug-nodejs into chore/add-missing-dev-deps
No description provided.